Skip to content

Fix Velocity-CTD Compatibility: call markLoginEventFired before LoginEvent#3

Merged
R00tB33rMan merged 1 commit into
GemstoneGG:masterfrom
MelodyYuuka:master
May 22, 2026
Merged

Fix Velocity-CTD Compatibility: call markLoginEventFired before LoginEvent#3
R00tB33rMan merged 1 commit into
GemstoneGG:masterfrom
MelodyYuuka:master

Conversation

@MelodyYuuka

Copy link
Copy Markdown

Velocity-CTD introduced the markLoginEventFired() method on ConnectedPlayer. Without calling this method, the login flow may not properly synchronize with Velocity-CTD's disconnect handling, leading to compatibility issues.

  • Fix compatibility with Velocity-CTD by calling markLoginEventFired() on ConnectedPlayer via reflection before firing the LoginEvent
  • Remove redundant DisconnectEvent firing when player disconnects during login, as Velocity-CTD's natural teardown path already handles this and prevents double-firing of disconnect events

Consistent with Velocity-CTD's login flow.

@R00tB33rMan

Copy link
Copy Markdown
Member

Once again, catching something we didn’t! Nice work. Looks like this works correctly locally so I’ll go ahead and merge

@R00tB33rMan R00tB33rMan merged commit cee2348 into GemstoneGG:master May 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants